@andrew-polk partially reviewed 27 files and all commit messages, made 3 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on josiahwall).

src/BloomBrowserUI/bookEdit/js/audioUtils.ts line 1 at r3 (raw file):

// taken out of audioRecording.ts to avoid the need for other

I'm thinking all these new little utility files would fit better in toolbox/talkingBook rather than js. But I could be missing something.

What do you think?

src/BloomBrowserUI/bookEdit/toolbox/talkingBook/showTalkingBookTool.ts line 13 at r4 (raw file):

        ?.getTheOneToolbox()
        .activateToolFromId(kTalkingBookToolId);
}

As far as I can tell, this file is not needed.

@andrew-polk reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on josiahwall).

src/BloomBrowserUI/bookEdit/toolbox/talkingBook/showTalkingBookTool.ts line 13 at r4 (raw file):

Hm. Not sure what I was seeing. Ignore.

@andrew-polk partially reviewed 12 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on josiahwall).

src/BloomBrowserUI/bookEdit/toolbox/talkingBook/audioRecording.ts line 114 at r6 (raw file):

const kEndTimeAttributeName: string = "data-audioRecordingEndTimes";
const kPlaybackOrderContainerClass: string =
    "bloom-playbackOrderControlsContainer";

What was the reason for moving this back in here?
There just wasn't a good place for the file?

In the age of AI, it is unlikely that we would update one without finding the other, but the shared constant was a protection against that. But one can definitely make the argument it isn't worth a whole file.

Not necessarily asking for a change, just curious why you put it back.

@josiahwall made 2 comments and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on andrew-polk).

src/BloomBrowserUI/bookEdit/toolbox/talkingBook/showTalkingBookTool.ts line 13 at r4 (raw file):

Ignored.

src/BloomBrowserUI/bookEdit/js/audioUtils.ts line 1 at r3 (raw file):

I moved all the files except for the xhtmlIdUtils.ts, because that was the only file that did not seem to be audio recording/talking book specific. The other ones made more sense to be in the talkingBook directory. Please let me know if I should move the other one too.

@andrew-polk resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on josiahwall).